Skip to content

Improve portal search radius#2580

Merged
benwoo1110 merged 1 commit into
mainfrom
per-search-and-reflect
Apr 27, 2021
Merged

Improve portal search radius#2580
benwoo1110 merged 1 commit into
mainfrom
per-search-and-reflect

Conversation

@benwoo1110

@benwoo1110 benwoo1110 commented Mar 4, 2021

Copy link
Copy Markdown
Member
  • Adds new ReflectHelper class to help in reflection used in CompatibilityLayer.
  • Adds support for 1.15+ method in setting portal search radius, while using Travel Agent for older mc versions.
  • Apply portal search radius to entities as well.

Requires #2586 to be merged first.

@benwoo1110 benwoo1110 force-pushed the per-search-and-reflect branch from a5a8b10 to e92c1ca Compare March 4, 2021 06:10
@benwoo1110

Copy link
Copy Markdown
Member Author

Test build:
Multiverse-Core-4.2.3-SNAPSHOT.zip

@benwoo1110 benwoo1110 added PR: Enhancement Pull requests to implement a feature or improvement in code. State: Needs Review By Dev Pull requests requires the approve of lead dev. labels Mar 7, 2021
@benwoo1110 benwoo1110 force-pushed the per-search-and-reflect branch from 60662b2 to 8990beb Compare March 8, 2021 08:28
@nicegamer7

Copy link
Copy Markdown
Member

#2586 was merged, so this should probably be rebased. I can do it if you want.

@benwoo1110

Copy link
Copy Markdown
Member Author

I made this PR commits after those in #2586 specifically to avoid needing to rebase this PR

@benwoo1110

Copy link
Copy Markdown
Member Author

oh wait maybe it needs rebasing lol

@nicegamer7

Copy link
Copy Markdown
Member

Hold on, I'll trigger Travis to retry, then we'll see if GH can auto-merge.

* Fix portal search radius not respected after travel agent removed.
* Set portal search radius for entity entering portals.
@benwoo1110 benwoo1110 force-pushed the per-search-and-reflect branch from 8990beb to 3bb8de6 Compare April 26, 2021 14:53
@benwoo1110

Copy link
Copy Markdown
Member Author

Should be all good now

@nicegamer7 nicegamer7 self-requested a review April 26, 2021 14:54

@nicegamer7 nicegamer7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍!

@benwoo1110 benwoo1110 merged commit 2ee5aea into main Apr 27, 2021
@nicegamer7 nicegamer7 deleted the per-search-and-reflect branch July 22, 2021 00:34
This was referenced May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Enhancement Pull requests to implement a feature or improvement in code. State: Needs Review By Dev Pull requests requires the approve of lead dev.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants